-----Original Message-----
From: Mike Christie <micha...@cs.wisc.edu>
Date: Mon, 5 Mar 2012 03:35:09 -0800
To: Vikas Chaudhary <vikas.chaudh...@qlogic.com>
Cc: "open-iscsi@googlegroups.com" <open-iscsi@googlegroups.com>, Ravi
Anand <ravi.an...@qlogic.com>, Lalit Chandivade
<lalit.chandiv...@qlogic.com>
Subject: Re: [PATCH 2/3] iscsi tools: added ping support

>On 02/16/2012 02:45 AM, vikas.chaudh...@qlogic.com wrote:
>> +
>> +    rc = iface_conf_read(iface);
>> +    if (rc) {
>> +            log_error("Could not read iface %s (%d).", iface->name, rc);
>> +            goto ping_exit;
>> +    }
>> +
>> +    if (strcmp(iface->bootproto, "dhcp") && !strstr(iface->ipaddress,
>>"."))
>> +            iface_type = ISCSI_IFACE_TYPE_IPV6;
>
>This should be iface_get_iptype().
>
>This brings up a question/problem. Do we want to go by the iface type
>that the kernel is using or the one that is in the iface conf file. They
>might not be in sync. The value might not even be setup in the iface
>conf file (I hit this issue when testing with a setup that was
>previously setup with the qlogic app).
>
>Let me know what you think. I will fix it up when I merge.

We should go with iface type that kernel is using.


This message and any attached documents contain information from QLogic 
Corporation or its wholly-owned subsidiaries that may be confidential. If you 
are not the intended recipient, you may not read, copy, distribute, or use this 
information. If you have received this transmission in error, please notify the 
sender immediately by reply e-mail and then delete this message.

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To post to this group, send email to open-iscsi@googlegroups.com.
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/open-iscsi?hl=en.

Reply via email to