-----Original Message----- From: Mike Christie <micha...@cs.wisc.edu> Date: Mon, 5 Mar 2012 03:42:13 -0800 To: "open-iscsi@googlegroups.com" <open-iscsi@googlegroups.com> Cc: Vikas Chaudhary <vikas.chaudh...@qlogic.com>, Lalit Chandivade <lalit.chandiv...@qlogic.com>, Ravi Anand <ravi.an...@qlogic.com>, Nilesh Javali <nilesh.jav...@qlogic.com> Subject: Re: [PATCH 1/2] iscsi-tools: Add support to display CHAP list and delete
>On 02/27/2012 06:10 AM, vikas.chaudh...@qlogic.com wrote: >> +/* chap fields */ >> +#define CHAP_INDEX "chap.chap_tbl_idx" >> +#define CHAP_USERNAME "chap.username" >> +#define CHAP_PASSWORD "chap.password" >> +#define CHAP_PASSWORD_LEN "chap.password_length" >> +#define CHAP_TYPE "chap.chap_type" >> + > >Currently we have: > >node.session.auth.username >node.session.auth.password >node.session.auth.username_in >node.session.auth.password_in > >discovery.sendtargets.auth.username >discovery.sendtargets.auth.password >discovery.sendtargets.auth.username_in >discovery.sendtargets.auth.password_in > >So the print code should display it in a similar way. For example >instead of printing out chap_type it should use the proper setting from >above. I will fix that up when merging. > >My question, how does the card handle discovery vs normal session chap >settings. Are they all in the same table, or should they be separated >like above. They are all in same table and they are host global. > >If they are all in the same table and are host global then maybe >renaming the ones you were adding to > >host.auth.username >host.auth.password >host.auth.username_in >host.auth.password_in > >is going to be a better fit for how we currently name things? > Yes, Looks better. This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to open-iscsi@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.