Replacing linux-scsi list with linux-kernel.

On Aug 12, 2012, at 9:15 AM, Masatake YAMATO <yam...@redhat.com> wrote:

> In iscsi_free_task, NULL is assigned to task->sc twice: before and
> after kfifo_in invocatoin. Allocating and freeing iscsi_task are guarded
> with session->lock, so multiple NULL assignments cause no trouble. But
> people reading the source code may be confused.
> 
> The second NULL assignment comes from commit:
> 
>    3e5c28ad0391389959ccae81c938c7533efb3490
> 
> It seems that the line after kfifo_in invocation was introduced
> accidentally.
> 
> Signed-off-by: Masatake YAMATO <yam...@redhat.com>
> ---
> drivers/scsi/libiscsi.c | 1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
> index 82c3fd4..7aacf3a 100644
> --- a/drivers/scsi/libiscsi.c
> +++ b/drivers/scsi/libiscsi.c
> @@ -500,21 +500,20 @@ static void iscsi_free_task(struct iscsi_task *task)
>       task->sc = NULL;
>       /*
>        * login task is preallocated so do not free
>        */
>       if (conn->login_task == task)
>               return;
> 
>       kfifo_in(&session->cmdpool.queue, (void*)&task, sizeof(void*));
> 
>       if (sc) {
> -             task->sc = NULL;
>               /* SCSI eh reuses commands to verify us */
>               sc->SCp.ptr = NULL;
>               /*
>                * queue command may call this to free the task, so
>                * it will decide how to return sc to scsi-ml.
>                */
>               if (oldstate != ISCSI_TASK_REQUEUE_SCSIQ)
>                       sc->scsi_done(sc);
>       }

Looks ok to me.

Reviewed-by: Mike Christie <micha...@cs.wisc.edu>

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To post to this group, send email to open-iscsi@googlegroups.com.
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/open-iscsi?hl=en.

Reply via email to