On Nov 3, 2012, at 10:51 AM, Amit <amit.ut...@gmail.com> wrote: > Mike Christie <michaelc@...> writes: > >>> Regarding dev_loss_tmo, this has to be implemented at the kernel level >>> correct? Since this feature is important to me, I can go ahead and try >>> to implement that. >>> >> >> Ok. Here is some info on the current status: >> >> Implement iSCSI dev loss support. >> >> Currently if a session is down for longer than replacement/recovery_timeout >> seconds, the iscsi layer will unblock the devices and fail IO. Other >> transport, like FC and SAS, will do something similar. FC has a >> fast_io_fail tmo which will unblock devices and fail IO, then it has a >> dev_loss_tmo which will delete the devices accessed through that port. >> >> iSCSI needs to implement dev_loss_tmo behavior, because apps are beginning >> to expect this behavior. An initial path was made here: >> http://groups.google.com/group/open-iscsi/msg/031510ab4cecccfd?dmode=source >> >> Since all drivers want this behavior we want to make it common. We need to >> change the patch in that link to add a dev_loss_tmo handler callback to the >> scsi_transport_template struct, and add some common sysfs and helpers >> functions to manage the dev_loss_tmo variable. >> > > Looked at the patch and with a little modification I was able to apply > it to kernel 3.2.14. It works as advertised, thank you so much! The > device gets removed after a certain number of seconds and I get a udev > event that the device was removed. > > Any reason why this patch is not in the mainline? The only thing I > noticed is that there are potential race conditions since the mutex was > removed.
I have to retest. With the original code there was a hang/lockup due to some threading/workqueue issue. That code has not been rewritten in the upstream kernel and I think those changes fix my issue. -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to open-iscsi@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
