-----Original Message----- From: Admin <[email protected]> Date: Friday 1 February 2013 10:11 AM To: Mike Christie <[email protected]>, "[email protected]" <[email protected]> Cc: Lalit Chandivade <[email protected]>, Ravi Anand <[email protected]>, Poornima Vonti <[email protected]>, Manish Rangankar <[email protected]>, Adheer Chandravanshi <[email protected]> Subject: Re: [RFC_V4 PATCH 1/2] scsi_transport_iscsi: Add flash target mgmt support
> >-----Original Message----- >From: Mike Christie <[email protected]> >Date: Monday 28 January 2013 4:47 PM >To: "[email protected]" <[email protected]> >Cc: Vikas <[email protected]>, Lalit Chandivade ><[email protected]>, Ravi Anand <[email protected]>, >Poornima Vonti <[email protected]>, Manish Rangankar ><[email protected]>, Adheer Chandravanshi ><[email protected]> >Subject: Re: [RFC_V4 PATCH 1/2] scsi_transport_iscsi: Add flash target >mgmt support > >>On 01/11/2013 05:50 AM, [email protected] wrote: >>> From: Adheer Chandravanshi <[email protected]> >>> >>> This patch allows iscsiadm to manage iSCSI target information stored on >>> adapter flash on per host basis. >>> >>> The sysfs entries will look as cited below: >>> /sys/class/iscsi_flash_tgt/tgt-<host_no>-<target_no>/ >>> >>> Signed-off-by: Adheer Chandravanshi <[email protected]> >>> Signed-off-by: Vikas Chaudhary <[email protected]> >>> --- >>> drivers/scsi/scsi_transport_iscsi.c | 690 >>>++++++++++++++++++++++++++++++++++- >>> include/scsi/iscsi_if.h | 106 ++++++ >>> include/scsi/scsi_transport_iscsi.h | 35 ++ >>> 3 files changed, 830 insertions(+), 1 deletions(-) >>> >>> diff --git a/drivers/scsi/scsi_transport_iscsi.c >>>b/drivers/scsi/scsi_transport_iscsi.c >>> index dac7f8d..028f2c3 100644 >>> --- a/drivers/scsi/scsi_transport_iscsi.c >>> +++ b/drivers/scsi/scsi_transport_iscsi.c >>> @@ -25,6 +25,7 @@ >>> #include <linux/slab.h> >>> #include <linux/bsg-lib.h> >>> #include <linux/idr.h> >>> +#include <linux/list.h> >>> #include <net/tcp.h> >>> #include <scsi/scsi.h> >>> #include <scsi/scsi_host.h> >>> @@ -460,6 +461,431 @@ void iscsi_destroy_iface(struct iscsi_iface >>>*iface) >>> EXPORT_SYMBOL_GPL(iscsi_destroy_iface); >>> >>> /* >>> + * Interface to display flash tgt params to sysfs >>> + */ >>> + >>> +static void iscsi_flash_tgt_release(struct device *dev) >>> +{ >>> + struct iscsi_flash_tgt *tgt = iscsi_dev_to_flash_tgt(dev); >>> + struct device *parent = tgt->dev.parent; >>> + >>> + kfree(tgt); >>> + put_device(parent); >>> +} >>> + >>> + >>> +static struct class iscsi_flash_tgt_class = { >>> + .name = "iscsi_flash_tgt", >>> + .dev_release = iscsi_flash_tgt_release, >>> +}; >>> + >> >> >>I guess we are supposed to be using buses now. See the recent fcoe >>discussions and the code that got merged. > >Ok. We will submit next RFC patch using buses. Mike, We are sending following RFC_V5 patches in next emails. As per your suggestion we have made following major changes from RFC_V4 to RFC_V5, 1. Exporting flash target data in /sys/bus/iscsi_flashnode/* 2. Session and connection params are exported separatly /sys/bus/iscsi_flashnode/devices/flashnode_sess-<host_no>:<flashnode_id>/< session attrs> /sys/bus/iscsi_flashnode/devices/flashnode_conn-<host_no>:<flashnode_id>:< conn_id>/<conn attrs> 3. Modified iscsiadm code to accept multiple params. 4. Update operation directly writes to flash. Apply operation is removed. Kernel Patches:- Adheer Chandravanshi (3): scsi_transport_iscsi: Add flash node mgmt support libiscsi: export function iscsi_switch_str_param qla4xxx: Add flash node mgmt support Open-iscsi Patch:- iscsiadm: Add flash node mgmt support. Thanks, Vikas. ________________________________ This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/open-iscsi?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
