On Feb 19, 2013, at 3:07 AM, Ulrich Windl <ulrich.wi...@rz.uni-regensburg.de> 
wrote:

>>>> Michael Christie <micha...@cs.wisc.edu> schrieb am 19.02.2013 um 06:42 in
> Nachricht <75829b62-f5b7-4a3e-9adb-b1e888a31...@cs.wisc.edu>:
> 
>> On Feb 18, 2013, at 1:43 AM, Jan Engelhardt <jeng...@inai.de> wrote:
> [...]
>> 
>>> iscsiadm: discovery record [10.10.7.115,3260] not found!
>>> linux-d9i5:~ # iscsiadm -m discovery -t st -p 10.10.7.115
>>> 10.10.7.115:3260,1 
>>> iqn.2003-01.org.linux-iscsi.rtsnode1.x8664:sn.c4678a837b19
>>> linux-d9i5:~ # iscsiadm -m discovery -t SendTargets -p 10.10.7.115
>> 
>> Because of the mixed case SendTargets is hitting the unknown discovery type 
>> code paths, and tries to look for discovery records with the ip passed in. 
>> The first time you ran the command there were none so it reported error. 
>> Here 
>> you did a successful discovery command above, so it printed the discovery 
>> record info. that was setup when you ran the successful discovery command.
> 
> Mike,
> 
> what about a warning like this:
> "Warning: using unknown discovery type \"%s\"..."
> 
> I don't know the internals, but if the code gets lost anyway for an unknown 
> discovery type, the warning should be an error. It's a bad idea to let the 
> code get lost for unexpected input.


You are right. There are a couple places where we go down the default path when 
bad input is passed in. I am going to fix that in a bit. I am having hard drive 
issues right now, so will probably get to it later this week.

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at http://groups.google.com/group/open-iscsi?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to