On 06/26/2013 01:57 PM, Lee Duncan wrote: > openSUSE Build Service compiler noticed that one discovery > error path did not have a return value, so an appropriate > error is now being returned. > > Signed-of-by: Lee Duncan <[email protected]> > > --- > include/iscsi_err.h | 2 ++ > usr/iscsiadm.c | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/include/iscsi_err.h b/include/iscsi_err.h > index 1139133..125f443 100644 > --- a/include/iscsi_err.h > +++ b/include/iscsi_err.h > @@ -64,6 +64,8 @@ enum { > ISCSI_ERR_BUSY = 28, > /* Operation failed, but retrying layer may succeed */ > ISCSI_ERR_AGAIN = 29, > + /* unknown discovery type */ > + ISCSI_ERR_UNKNOWN_DISCOVERY_TYPE = 30, > > /* Always last. Indicates end of error code space */ > ISCSI_MAX_ERR_VAL, > diff --git a/usr/iscsiadm.c b/usr/iscsiadm.c > index 84d5a27..5030894 100644 > --- a/usr/iscsiadm.c > +++ b/usr/iscsiadm.c > @@ -1235,6 +1235,7 @@ sw_discovery: > return do_isns(drec, ifaces, info_level, do_login, op); > default: > log_debug(1, "Unknown Discovery Type : %d\n", drec->type); > + return ISCSI_ERR_UNKNOWN_DISCOVERY_TYPE; > } > } > >
Thanks. Merged in commit d9e26d3b94e0c7e874fedcf9cf578be7e9c8389b. -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/groups/opt_out.
