On Jun 27, 2013, at 2:57 PM, Or Gerlitz <or.gerl...@gmail.com> wrote:
> On Thu, Jun 27, 2013 at 7:25 PM, Mike Christie <micha...@cs.wisc.edu> wrote:
>>
>> On 06/27/2013 08:46 AM, Or Gerlitz wrote:
>>> @@ -501,6 +503,18 @@ iscsi_iser_set_param(struct iscsi_cls_conn
>>> *cls_conn,
>>> return -EPROTO;
>>> }
>>> break;
>>> + case ISCSI_PARAM_DISCOVERY_SESS:
>>> + sscanf(buf, "%d", &value);
>>> + conn = cls_conn->dd_data;
>>> + session = conn->session;
>>> + if (value) {
>>> + session->discovery_sess = 1;
>>> + iser_err("session is discovery!\n");
>>> + } else {
>>> + session->discovery_sess = 0;
>>> + iser_err("session is normal!\n");
>>> + }
>>> + break;
>>> default:
>>
>> This should go into libiscsi.c iscsi_set_param() since it is the same
>> for all drivers.
>
> I see, are you OK with this being still one patch that touches iser
> but also adds this case to iscsi_set_param()? do we have any evidence
That is fine with me although as you know some other reviewers prefer the one
patch per change. So you can risk it if you want.
> that the two patches this one depends on are going to be merged for
> 3.11?
James tried to merge it for 3.11, but it got dropped due to a merging conflict,
so next release.
>
>> You also need to add ISCSI_PARAM_DISCOVERY_SESS in iser_attr_is_visible
>> so that the transport class will setup the sysfs file stuff for it.
>
> thanks, BTW what happens if I don't do that, is set_param for this
> item from user-space not going to reach the kernel, or something else.
Right. If you do not set it then the sysfs file to read it will not get set and
the kernel code will not call into the driver/lib/class to set it.
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/groups/opt_out.
