On 07/31/2013 11:18 AM, Or Gerlitz wrote: > On Wed, Jul 31, 2013 at 6:58 PM, Michael Christie <micha...@cs.wisc.edu > <mailto:micha...@cs.wisc.edu>> wrote: > > > On Jul 31, 2013, at 5:35 AM, Or Gerlitz <ogerl...@mellanox.com > <mailto:ogerl...@mellanox.com>> wrote: > > > To run discovery over iSER we need to advertize the CAP_TEXT_NEGO > capability > > towards user space. Also need to make sure the login RX buffer is > posted when > > SendTargets TEXT PDUs are sent. For that end, we use a setting of the > > ISCSI_PARAM_DISCOVERY_SESS iscsi param as an indication that this > is discovery > > session. > > > > Signed-off-by: Or Gerlitz <ogerl...@mellanox.com > <mailto:ogerl...@mellanox.com>> > > --- > > > > changes from V0: > > > > - applied feedback from Mike > > -- moved the iscsi_set_param part to libiscsi.c > > -- advertize ISCSI_PARAM_DISCOVERY_SESS too in iser_attr_is_visible > > > > To apply this patch need to pick these two patches > > > > [PATCH V1 1/4] scsi_transport_iscsi: Exporting new attrs for iscsi > session and connection in sysfs > > http://marc.info/?l=linux-scsi&m=137225028829588&w=2 > > > > [PATCH V1 2/4] libiscsi: Exporting new attrs for iscsi session and > connection in sysfs > > http://marc.info/?l=linux-scsi&m=137225028829588&q=raw > > Patch looks ok to me. Did you intend for me to pass this along to > linux-scsi/James or did you mean to cc that list or were you going > to resend to that list? Let me know what you prefer. It does not > matter to me. > > > > > I wanted to get your review so when I send to James I can add your ack > or signature... which should I add? >
Just send to linux-scsi. When it goes there I will respond to the mail with a Reviewed-by email. That sequence seems to be most successful. If you send to the list with my Reviewed/Acked line already on it, I have noticed James will sometimes not pick it up. It might be due to his email rules/filters. -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to firstname.lastname@example.org. Visit this group at http://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/groups/opt_out.