On 17/10/2013 02:23, Mike Christie wrote:
I know you guys sent a new version of the patch, but I am commenting on just the specific issue below because we started the discussion here.This chunk in __iscsi_update_cmdsn: if (max_cmdsn != session->max_cmdsn && !iscsi_sna_lt(max_cmdsn, session->max_cmdsn)) { session->max_cmdsn = max_cmdsn; /* * if the window closed with IO queued, then kick the * xmit thread */ if (!list_empty(&session->leadconn->cmdqueue) || !list_empty(&session->leadconn->mgmtqueue)) iscsi_conn_queue_work(session->leadconn); looks not needed. We never will have a closed window and something on one of those lists. If we did we could miss a case we need to wake up the xmit thread because they are using different locks. On the next sending of your patchset could you send a patch to delete that chunk above or delete that chunk in the main patch. Will send other comments in other thread where the new version of the patch is on.
Mike, just to make sure we're on the same page, you would like to see the removal of this code section as pre patch to this series, correct? no problem, just get us some more feedback on V1...
Or. -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/groups/opt_out.
