On 11/14/2013 05:53 PM, micha...@cs.wisc.edu wrote: > From: Yufei Ren <yufei....@stonybrook.edu> > > Got "can not connect to iSCSI daemon (111)!" error during > starting iscsi service by: > $ iscsiadm -m node --loginall=all > > Traced down and found that the sun_path was mis-used in both iscsid > and iscsiadm. > --- > usr/iscsid_req.c | 2 +- > usr/mgmt_ipc.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/usr/iscsid_req.c b/usr/iscsid_req.c > index 715c0aa..0ebde90 100644 > --- a/usr/iscsid_req.c > +++ b/usr/iscsid_req.c > @@ -71,7 +71,7 @@ static int ipc_connect(int *fd, char *unix_sock_name, int > start_iscsid) > > memset(&addr, 0, sizeof(addr)); > addr.sun_family = AF_LOCAL; > - memcpy((char *) &addr.sun_path + 1, unix_sock_name, > + memcpy((char *) addr.sun_path + 1, unix_sock_name, > strlen(unix_sock_name)); >
Hey, since we have some eyes on this patch, one question I have is why is the + 1 in there for? Is should not be there right? -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.com. Visit this group at http://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/groups/opt_out.