On 03/21/2014 01:21 AM, John Soni Jose wrote: > Issue : > During login negotiation if the MaxRecvDataSegmenLen given by the > target is 0, then MRDSL default value of 8K should be considered. > Some old targets close the CXN if the PDU received size is greater > than the MaxRecvDataSegmentLen set during negotiation. > > Fix : > When target is not sending MaxRecvDataSegmentLen in the negotiated > params the value is 0. be2iscsi was setting max_xmit_dlength to 64k > in this case. This fix sets the MaxRecvDataSegmentLen=8k if during > negotiation the MaxRecvDataSegmentLen=0 > > Signed-off-by: John Soni Jose <[email protected]> > Signed-off-by: Jayamohan Kallickal <[email protected]> > --- > usr/be2iscsi.c | 4 ---- > 1 files changed, 0 insertions(+), 4 deletions(-) > > diff --git a/usr/be2iscsi.c b/usr/be2iscsi.c > index ce8b719..ba4c29f 100644 > --- a/usr/be2iscsi.c > +++ b/usr/be2iscsi.c > @@ -33,10 +33,6 @@ void be2iscsi_create_conn(struct iscsi_conn *conn) > if (conn->max_xmit_dlength > 65536) > conn->max_xmit_dlength = 65536; > > - if (!conn_rec->iscsi.MaxXmitDataSegmentLength || > - conn_rec->iscsi.MaxXmitDataSegmentLength > 65536) > - conn_rec->iscsi.MaxXmitDataSegmentLength = 65536; > - > session->erl = 0; > session->initial_r2t_en = 1; > } >
This one looks like it is not needed anymore. I think we fixed this in the upstream code already. -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout.
