On 06/30/2014 07:16 PM, Mike Christie wrote:
On 06/30/2014 11:34 AM, Mike Christie wrote:
On 06/30/2014 04:43 AM, Hannes Reinecke wrote:
Hi Mike,

iscsistart has the Target Portal Group Tag (tpgt) set to 'required', ie
without specifying it iscsistart won't attempt to connect to the target.

Now as we're not supporting MC/S anyway, the usage of tpgt is pretty
much defined by the target, ie we should be using whatever the target
presents to us.

And there is no way of specifying the tpgt when using DHCP; RFC4173
doesn't know about this and consequently doesn't specify it.

Can't we get rid of the mandatory usage in iscsistart and have it use
the target-provided tpgt?


Yes. The login.c code was modified to not require the tpgt, but I am not
sure why I never fixed iscsistart.c.

If you have a patch send it. If not then I just removed the tpgt check
from check_params and I will test it later today.


The attached patch works for me.

Hmm. _That_ I could've done myself :-)

Nevertheless, I'll be testing it.
Thanks.

Cheers,

Hannes
--
Dr. Hannes Reinecke                   zSeries & Storage
[email protected]                          +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)

--
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

Reply via email to