>>> Mike Christie <[email protected]> schrieb am 26.08.2014 um 09:10 in
Nachricht <[email protected]>:

[...]
> The attached patch should fix this. It just rounds down instead of
> rounding up.

As round_down_on_pad_bound(unsigned int param) does not do any "padding" at 
all, but "alignment", why not simply call it "allign_32_down()"?
(The old code tod align to 32 bit; so I guess the new code also does. If it 
will align to anything larger on 64 bit architectures, the "_32" should vanish, 
of course)

Actually it should be "alligned_32_down()", because it doesn't modify the 
original value, but it's a "const" function (in the gcc sense ("Function 
Attributes")).

Regards,
Ulrich

> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "open-iscsi" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to [email protected].
> To post to this group, send email to [email protected].
> Visit this group at http://groups.google.com/group/open-iscsi.
> For more options, visit https://groups.google.com/d/optout.



-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

Reply via email to