On Tuesday, November 11, 2014 8:25:56 PM UTC-8, Mike Christie wrote: > > On 10/30/2014 08:16 PM, The Lee-Man wrote: > > 0002-Represent-DHCP-origin-as-an-integer-not-string.patch > > > > This just changes the "origin" attribute from a string, to a number, > > which > > is what it really is. > > > > Could you send me a link to where origin is defined? In the doc I have > it is a dead link. >
This is defined in the iBFT document, available here on the web here: iBFT Layout - Microsoft <http://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=1&ved=0CCAQFjAA&url=http%3A%2F%2Fdownload.microsoft.com%2Fdownload%2F7%2FE%2F7%2F7E7662CF-CBEA-470B-A97E-CE7CE0D98DC2%2FiBFT.docx&ei=TjZlVKeNKYzVoASDn4GAAw&usg=AFQjCNHY7NV8Y8wg4cHMzEOHi-4oUnWNLQ&sig2=9mkbWXrDlIra2lY3Qbe-Vg&bvm=bv.79400599,d.cGU> (if my hper-link works) In section 3.6 NIC Structure, the table shows that "origin" 1 byte long at offset 23 bytes. And table points at a C++ definition of the values here: http://msdn.microsoft.com/en-us/library/aa366281.aspx It looks like: typedef enum { IpPrefixOriginOther = 0, IpPrefixOriginManual, IpPrefixOriginWellKnown, IpPrefixOriginDhcp, IpPrefixOriginRouterAdvertisement, IpPrefixOriginUnchanged = 16 } IP_PREFIX_ORIGIN; The open-iscsi code current checks this for the value "3" (i.e. a string representing the number 3), and our code already has a patch that instead reads this value in as an integer, and then compares it with the number 3. > > 0004-Fixup-IPv6-iBFT-interface-description.patch > > > > This patch adds "prefix-len" to the open-iscsi attributes, as it > > is needed for IPv6, which doesn't use "mask" like IPv4 does. > > > > Could you send me a link to the prefix-len kernel patch that you guys > did, or did you reply the mail where I was asking what is it (if so I > cannot find it)? For the offload drivers that simulate ibft did they > report the correct value in your kernel patch? > > I think we should put patch 0004 on hold for now. It looks like Hannes submitted this patch here: https://lkml.org/lkml/2014/7/16/369 But there was an issue. I believe the issue was fixed but never fed back upstream, so I have to follow up on that. -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout.
