On 03/10/2015 11:52 AM, wei, xiaoyan wrote: > Hi Mike, > > I sent out an email regarding iscsiadm's discovery problem (attached). > Looks like Lee is referring the same problem and the patch will fix it. Could > you please confirm? >
My patch only cleans up the code that handles the problem when doing normal session login. I cleaned it up when fixing another bug in that code, and was only bygging Lee about the issue because I was looking for more info on how to hit it so I could test my patch. Lee - someone at RH ended up having a system btw. Ideally, we would want to have these type of issues fixed in one place. Due to how iscsiadm does not use iscsid though, I do not think that is possible though. > Thanks! > > > -----Original Message----- > From: [email protected] [mailto:[email protected]] On > Behalf Of Mike Christie > Sent: Tuesday, March 10, 2015 11:01 AM > To: [email protected] > Subject: Re: Problem setting host net params via iscsiuio on first try: bad > error message > > On 03/09/2015 08:54 PM, Lee Duncan wrote: >> Hi Mike: >> >> I am *finally* getting to this bug, previously buried under a mountain of >> more pressing matters. >> >>> On Jan 12, 2015, at 12:50 PM, Mike Christie <[email protected]> wrote: >>> >>> Thanks. I merged and pushed these patches. >>> >>> When you get some time, reply to that mail I sent offlist about how >>> long it is taking for the set host net params to succeed, so I can >>> fix my login/init patch as needed. >> >> I have looked at this problem again, and I will reply in a new email >> tomorrow. Fair warning. :) > > :) > > Hey, > > Attached is the patch that was modifying iscsid's code path which from what I > understand handled the same problem you were handling in the iscsiadm's > discovery code path. > > The patch is removing the iscsiuio specific calls in iscsid and using the > generic initial login/connect retry code. It is currently retrying for up to > login_timeout seconds instead of the hard coded 5 seconds. > > -- > You received this message because you are subscribed to the Google Groups > "open-iscsi" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/open-iscsi. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout.
