> -----Original Message----- > From: open-iscsi@googlegroups.com [mailto:open-iscsi@googlegroups.com] > On Behalf Of Mike Christie > Sent: Saturday, April 04, 2015 2:21 AM > To: open-iscsi@googlegroups.com > Cc: Lee Duncan > Subject: Re: [PATCH 1/1] ARP table too small when switches involved. > > On 04/01/2015 12:23 PM, Lee Duncan wrote: > > From: Lee Duncan <ldun...@suse.com> > > > > The default uIP approach is to hae a super-small memory foot print, > > but modern networks, with switches, need more than 8 ARP entries, > > discovered during IPv6 using, showing up as slow iscsiuio response. > > --- > > iscsiuio/src/uip/ipv6.h | 2 +- > > iscsiuio/src/uip/uipopt.h | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/iscsiuio/src/uip/ipv6.h b/iscsiuio/src/uip/ipv6.h index > > bc63762ebc55..35864377d9f3 100644 > > --- a/iscsiuio/src/uip/ipv6.h > > +++ b/iscsiuio/src/uip/ipv6.h > > @@ -270,7 +270,7 @@ struct ipv6_context { > > struct ipv6_addr default_router; > > struct ipv6_prefix_entry *addr_list; > > u8_t hop_limit; > > -#define UIP_ARPTAB_SIZE 8 > > +#define UIP_ARPTAB_SIZE 16 > > > > struct uip_stack *ustack; > > #define MAX_MCADDR_TABLE 5 > > diff --git a/iscsiuio/src/uip/uipopt.h b/iscsiuio/src/uip/uipopt.h > > index 946fce284926..bcc8949b8f16 100644 > > --- a/iscsiuio/src/uip/uipopt.h > > +++ b/iscsiuio/src/uip/uipopt.h > > @@ -341,7 +341,7 @@ > > #ifdef UIP_CONF_ARPTAB_SIZE > > #define UIP_ARPTAB_SIZE UIP_CONF_ARPTAB_SIZE #else -#define > > UIP_ARPTAB_SIZE 8 > > +#define UIP_ARPTAB_SIZE 16 > > #endif > > > > /** > > > > Patch looks ok to me. > > Adheer, you guys are the maintainer of the iscsiuio code, so you normally > review and ack if it is ok. I only normally merge if you have acked/reviewed > the patch. > > Thanks. >
The patch looks good. Acked-by: Adheer Chandravanshi <adheer.chandravan...@qlogic.com> Thanks, Adheer > -- > You received this message because you are subscribed to the Google Groups > "open-iscsi" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to open-iscsi+unsubscr...@googlegroups.com. > To post to this group, send email to open-iscsi@googlegroups.com. > Visit this group at http://groups.google.com/group/open-iscsi. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.com. Visit this group at http://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout.
