On Sun, May 24, 2015 at 04:56:26AM +0000, Adheer Chandravanshi wrote: > > ________________________________________ > From: [email protected] [[email protected]] on behalf of > Eddie Wai [[email protected]] > Sent: Friday, May 22, 2015 10:12 PM > To: [email protected] > Cc: Johannes Thumshirn; Adheer Chandravanshi > Subject: Re: [PATCH] iscsiuio: Fix lookup of IPv6 router address > > Hi, > > Don't mind if I chime in. From the upstream code, the patch looks good. > Just curious at who the caller for that might be? > > Eddie > > On Fri, 2015-05-22 at 10:48 -0500, Mike Christie wrote: > > CCing qlogic. > > > > Which one of you guys is watching over iscsiuio? > > > > > > On 5/21/15, 4:12 AM, Johannes Thumshirn wrote: > > > Gnetle ping on this > > > > > > On Mon, May 11, 2015 at 01:38:12PM +0200, Johannes Thumshirn wrote: > > >> When iscsiuio performs a lookup in it's routing table > > >> for the default router, nothing is returned as ndpc_request() > > >> didn't understand the 'GET_DEFAULT_ROUTER_ADDR' request. > > >> The solution is to add the request and return the default router > > >> address. > > >> > > >> Signed-off-by: Johannes Thumshirn <[email protected]> > > >> --- > > >> iscsiuio/src/uip/ipv6_ndpc.c | 3 +++ > > >> 1 file changed, 3 insertions(+) > > >> > > >> diff --git a/iscsiuio/src/uip/ipv6_ndpc.c b/iscsiuio/src/uip/ipv6_ndpc.c > > >> index 62d1c21..8422d7e 100644 > > >> --- a/iscsiuio/src/uip/ipv6_ndpc.c > > >> +++ b/iscsiuio/src/uip/ipv6_ndpc.c > > >> @@ -413,6 +413,9 @@ int ndpc_request(struct uip_stack *ustack, void *in, > > >> void *out, int request) > > >> (struct ipv6_addr *)((struct ndpc_reqptr *)in)->ipv6, > > >> (struct mac_address *)((struct ndpc_reqptr > > >> *)in)->eth); > > >> break; > > >> + case GET_DEFAULT_ROUTER_ADDR: > > >> + ipv6_get_default_router_ip_addrs(ipv6c, *(struct ipv6_addr > > >> **)out); > > >> + break; > > >> case GET_HOST_ADDR: > > >> *(struct ipv6_addr **)out = ipv6_find_longest_match(ipv6c, > > >> (struct ipv6_addr > > >> *)in); > > >> -- > > >> 2.3.7 > > >> > > > > > > > Oops! Sorry for the late response. It was lying in my drafts. > > Johannes, > > I agree with Eddie. The code looks good upstream wise. > But I do not see ndpc_request() being called in iscsiuio with > GET_DEFAULT_ROUTER_ADDR request. > Is there some different patch you are working on for that? > > Thanks, > Adheer >
Just re-checked, the patch is nonesense from an upstream point of view. Seems like I've been working on a bugfix that was already fixed upstream. Sorry for the noise. Johannes -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout.
