On 3/7/2017 10:52 AM, Reshetova, Elena wrote:

refcount_t type and corresponding API should be
used instead of atomic_t when the variable is used as
a reference counter. This allows to avoid accidental
refcounter overflows that might lead to use-after-free

Signed-off-by: Elena Reshetova <elena.reshet...@intel.com>
Signed-off-by: Hans Liljestrand <ishkam...@gmail.com>
Signed-off-by: Kees Cook <keesc...@chromium.org>
Signed-off-by: David Windsor <dwind...@gmail.com>
diff --git a/drivers/media/pci/cx88/cx88.h b/drivers/media/pci/cx88/cx88.h
index 115414c..16c1313 100644
--- a/drivers/media/pci/cx88/cx88.h
+++ b/drivers/media/pci/cx88/cx88.h
@@ -339,7 +340,7 @@ struct cx8802_dev;

 struct cx88_core {
        struct list_head           devlist;
-       atomic_t                   refcount;
+       refcount_t                   refcount;

    Could you please keep the name aligned with above and below?

You mean "not aligned" to devlist, but with a shift like it was before?

   I mean aligned, like it was before. :-)

Sure, will fix. Is the patch ok otherwise?

   I haven't noticed anything else...

Best Regards,

MBR, Sergei

You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

Reply via email to