>>> "wubo (T)" <[email protected]> schrieb am 30.10.2019 um 08:56 in Nachricht
<edbaaa0bbba2ac4e9c8b6b81deee1d6915dfa...@dggeml505-mbs.china.huawei.com>:
> From: Bo Wu <[email protected]>
...
> + if (--retries < 0) {
> + printk(KERN_ERR "Send reply failed too many
> times. "
> + "Max supported retries %u\n",
> ISCSI_SEND_MAX_ALLOWED);
Just for "personal taste": Why not simplify the message to:?
+ printk(KERN_ERR "Send reply failed too many
times (%u)\n",
ISCSI_SEND_MAX_ALLOWED);
> + break;
> + }
> +
Maybe place the number after "many" as an alternative. I think as the message
is expected to be rare, a short variant is justified.
Also one could discuss wether the problem that originates "from external"
should be KERN_ERR, or maybe just a warning, because the kernel itself can do
little against that problem, and it's not a "kernel error" after all ;-)
Regards,
Ulrich
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/open-iscsi/5DB946E1020000A100034B9C%40gwsmtp.uni-regensburg.de.
