I agree that the patch reduces lines of code, in that we would now have one call to verify params, rather than multiple calls. Also, as you say, we check a little sooner, although I don't think that's necessarily a feature.
But please change the wording of the submission to say something more like "Check mode parameters earlier and in one place"? Please submit this as a pull request on github.com under open-iscsi/open-iscsi, as that saves me the trouble of manually scraping the patch off the email and applying it myself. Thank you. On Friday, November 20, 2020 at 12:22:37 AM UTC-8 Uli wrote: > >>> Wenchao Hao <[email protected]> schrieb am 20.11.2020 um 07:20 in > Nachricht > <[email protected]>: > > Parameters verify should be performed as soon as possible > > to avoid unuseless work. > > "avoid unuseless work" ;-) > > Is that useful work? > > > > -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/open-iscsi/2cc4955d-b619-4af4-9f15-d2cd4224e18bn%40googlegroups.com.
