I will send a V2 patch.
----- 原始邮件 -----
发件人: "Joe Perches" <[email protected]>
收件人: "Guo Zhi" <[email protected]>, "Lee Duncan" <[email protected]>,
"Chris Leech" <[email protected]>, "James E.J. Bottomley" <[email protected]>,
"Martin K. Petersen" <[email protected]>
抄送: [email protected], [email protected], "linux-kernel"
<[email protected]>
发送时间: 星期六, 2021年 10 月 09日 上午 11:14:36
主题: Re: [PATCH] scsi scsi_transport_iscsi.c: fix misuse of %llu in
scsi_transport_iscsi.c
On Sat, 2021-10-09 at 11:02 +0800, Guo Zhi wrote:
> Pointers should be printed with %p or %px rather than
> cast to (unsigned long long) and printed with %llu.
> Change %llu to %p to print the pointer into sysfs.
][]
> diff --git a/drivers/scsi/scsi_transport_iscsi.c
> b/drivers/scsi/scsi_transport_iscsi.c
[]
> @@ -129,8 +129,8 @@ show_transport_handle(struct device *dev, struct
> device_attribute *attr,
>
>
> if (!capable(CAP_SYS_ADMIN))
> return -EACCES;
> - return sysfs_emit(buf, "%llu\n",
> - (unsigned long long)iscsi_handle(priv->iscsi_transport));
> + return sysfs_emit(buf, "%p\n",
> + iscsi_ptr(priv->iscsi_transport));
iscsi_transport is a pointer isn't it?
so why not just
return sysfs_emit(buf, "%p\n", priv->iscsi_transport);
?
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/open-iscsi/1054322431.5783331.1633754117686.JavaMail.zimbra%40sjtu.edu.cn.
