On 3/29/23 2:17 AM, Zhong Jinghua wrote:
> From: Zhong Jinghua <[email protected]>
> 
> The correctness of sock should be checked before assignment to avoid
> assigning wrong values.
> 
> Commit
> "scsi: iscsi: iscsi_tcp: Fix null-ptr-deref while calling getpeername()"
> introduced this change. This change may lead to inconsistent values of
> tcp_sw_conn->sendpage and conn->datadgst_en.
> 
> Fix it by moving the position of the assignment.
> 
> Fixes: 57569c37f0ad ("scsi: iscsi: iscsi_tcp: Fix null-ptr-deref while 
> calling getpeername()")
> Signed-off-by: Zhong Jinghua <[email protected]>

Thanks.

Reviewed-by: Mike Christie <[email protected]>

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/open-iscsi/15e892ef-0ab4-b2c9-bfc7-6cc3ba221c4a%40oracle.com.

Reply via email to