session might contain private part of the password, so better use kfree_sensitive() to free it. In iscsi_session_free() use kfree_sensitive() to free session->password, session->password_in, session->username, session->username_in.
Signed-off-by: Minjie Du <dumin...@vivo.com> --- drivers/scsi/libiscsi.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c index 0fda8905e..a307da898 100644 --- a/drivers/scsi/libiscsi.c +++ b/drivers/scsi/libiscsi.c @@ -3132,10 +3132,10 @@ void iscsi_session_free(struct iscsi_cls_session *cls_session) struct module *owner = cls_session->transport->owner; iscsi_pool_free(&session->cmdpool); - kfree(session->password); - kfree(session->password_in); - kfree(session->username); - kfree(session->username_in); + kfree_sensitive(session->password); + kfree_sensitive(session->password_in); + kfree_sensitive(session->username); + kfree_sensitive(session->username_in); kfree(session->targetname); kfree(session->targetalias); kfree(session->initiatorname); -- 2.39.0 -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/open-iscsi/20230719074534.5311-1-duminjie%40vivo.com.