On 2023/9/22 22:53, Bart Van Assche wrote:
On 9/22/23 02:38, Wenchao Hao wrote:
Add comment to tell callback function target_destroy of
scsi_host_template is called in atomic context.

Signed-off-by: Wenchao Hao <haowench...@huawei.com>
---
  include/scsi/scsi_host.h | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h
index 49f768d0ff37..a72248fa5adf 100644
--- a/include/scsi/scsi_host.h
+++ b/include/scsi/scsi_host.h
@@ -245,6 +245,9 @@ struct scsi_host_template {
       * midlayer calls this point so that the driver may deallocate
       * and terminate any references to the target.
       *
+     * Note: this callback in called with spin_lock held, so donot
+     * call functions might cause schedule
+     *

This comment should mention which spinlock is held.


Would update, thanks for your review suggestion.

Thanks,

Bart.



--
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/open-iscsi/f2fb9e25-c022-58d2-ac56-db35c2edfedf%40huawei.com.

Reply via email to