I see there's a spelling error in the description, so I'll resubmit. On Sun, Nov 17, 2024 at 11:46 AM Lee Duncan <[email protected]> wrote: > > From: Lee Duncan <[email protected]> > > The username and password checks were backwards for the sysfs > visibility checks, so correct them. This likely went unnoticed, > since the visibility/writability for these attributes > (username/password and mututual username/password) are all > the same. > > Fixes: 1d063c17298d ('[SCSI] iscsi class: sysfs group is_visible callout for > session attrs') > Signed-off-by: Lee Duncan <[email protected]> > --- > drivers/scsi/scsi_transport_iscsi.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/scsi/scsi_transport_iscsi.c > b/drivers/scsi/scsi_transport_iscsi.c > index fde7de3b1e55..81c57e0e8d90 100644 > --- a/drivers/scsi/scsi_transport_iscsi.c > +++ b/drivers/scsi/scsi_transport_iscsi.c > @@ -4587,13 +4587,13 @@ static umode_t iscsi_session_attr_is_visible(struct > kobject *kobj, > else if (attr == &dev_attr_sess_chap_out_idx.attr) > param = ISCSI_PARAM_CHAP_OUT_IDX; > else if (attr == &dev_attr_sess_password.attr) > - param = ISCSI_PARAM_USERNAME; > + param = ISCSI_PARAM_PASSWORD; > else if (attr == &dev_attr_sess_password_in.attr) > - param = ISCSI_PARAM_USERNAME_IN; > + param = ISCSI_PARAM_PASSWORD_IN; > else if (attr == &dev_attr_sess_username.attr) > - param = ISCSI_PARAM_PASSWORD; > + param = ISCSI_PARAM_USERNAME; > else if (attr == &dev_attr_sess_username_in.attr) > - param = ISCSI_PARAM_PASSWORD_IN; > + param = ISCSI_PARAM_USERNAME_IN; > else if (attr == &dev_attr_sess_fast_abort.attr) > param = ISCSI_PARAM_FAST_ABORT; > else if (attr == &dev_attr_sess_abort_tmo.attr) > -- > 2.43.0 >
-- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion visit https://groups.google.com/d/msgid/open-iscsi/CAPj3X_XGSQswf%3Diw_7ekfDaed6JGZMs_%2B%3DRb9fgTKZ9Cj0TYAQ%40mail.gmail.com.
