On 3/18/25 4:43 AM, [email protected] wrote: > From: Miaoqian Lin <[email protected]> > > Add goto to ensure scsi_host_put is called in all error paths of > iscsi_set_host_param function. This fixes a potential memory leak when > strlen check fails. > > Fixes: ce51c8170084 ("scsi: iscsi: Add strlen() check in > iscsi_if_set{_host}_param()") > Signed-off-by: Miaoqian Lin <[email protected]> > --- > drivers/scsi/scsi_transport_iscsi.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/scsi_transport_iscsi.c > b/drivers/scsi/scsi_transport_iscsi.c > index 9c347c64c315..0b8c91bf793f 100644 > --- a/drivers/scsi/scsi_transport_iscsi.c > +++ b/drivers/scsi/scsi_transport_iscsi.c > @@ -3182,11 +3182,14 @@ iscsi_set_host_param(struct iscsi_transport > *transport, > } > > /* see similar check in iscsi_if_set_param() */ > - if (strlen(data) > ev->u.set_host_param.len) > - return -EINVAL; > + if (strlen(data) > ev->u.set_host_param.len) { > + err = -EINVAL; > + goto out; > + } > > err = transport->set_host_param(shost, ev->u.set_host_param.param, > data, ev->u.set_host_param.len); > +out: > scsi_host_put(shost); > return err; > }
Reviewed-by: Mike Christie <[email protected]> -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion visit https://groups.google.com/d/msgid/open-iscsi/9dfb46b3-3dfe-40ea-9eae-c6a2533ad950%40oracle.com.
