[ http://issues.apache.org/jira/browse/OPENJPA-63?page=comments#action_12444414 ] Patrick Linskey commented on OPENJPA-63: ----------------------------------------
For a change this small, I'm perfectly happy with doing the logic in a single class. We should keep an eye out for the logic diverging more and more, and create a separate class / subclass as needed at that time. Also, Igor's changes to DelegatingDatabaseMetaData will have the unfortunate side-effect of requiring that we compile against JDK1.4 -- JDK1.3 java.sql.DelegatingDatabaseMetaData didn't have those two methods. Most of the methods in our JDBC package that throw exceptions do so to allow us to run against more recent versions of java.sql than we compile against. Personally, I'd rather maintain the OpenJPA 1.3 support. This, however, would require either doing some reflection (plus a call to DelegatingDatabaseMetaData.getInnermostDelegate()) in the DBDictionary, or just using SQL to ask the database about it's version, or getting the verison data from some other 1.3-supported source. > Better pessimistic lock support for DB2 v8.2+ > --------------------------------------------- > > Key: OPENJPA-63 > URL: http://issues.apache.org/jira/browse/OPENJPA-63 > Project: OpenJPA > Issue Type: Improvement > Components: jdbc > Environment: IBM DB2 UDB v8.2 or later > Reporter: Igor Fedorenko > Attachments: db2-selectForUpdate.patch > > > There is new SELECT "FOR READ ONLY WITH RS USE AND KEEP EXCLUSIVE LOCKS" > syntax in DB2 v8.2 and later that can be used to implement pessimistic locks > for selects with multiple from tables, subselects, inner/outer joins and so > forth. I'll attach simple patch shortly. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
