[
https://issues.apache.org/jira/browse/OPENJPA-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473743
]
Patrick Linskey commented on OPENJPA-144:
-----------------------------------------
I'm guessing that Approach 2 works with just a single jta-data-source listed,
right?
Also, your description implies that with the most recent code, OpenJPA is
looking up the non-jta-data-source, but WAS is still returning a data source
with limitations. Is that correct? Based on this assumption, I will close this
issue and create a new one re: our defaults and corresponding WAS limitations.
> JDBCConfigurationImpl does not support JNDI lookup for non-jta-data-source.
> -----------------------------------------------------------------------------
>
> Key: OPENJPA-144
> URL: https://issues.apache.org/jira/browse/OPENJPA-144
> Project: OpenJPA
> Issue Type: Bug
> Components: jdbc
> Environment: WebSphere 6.1, DB2 v8.1 and sequences
> Reporter: Brad L Vandermoon
> Attachments: Both-JTAandNonJTASpecified.txt, Only-JTASpecified.txt,
> openjpa-144-patch-2.jar, OPENJPA-144-patch.diff, openjpa-144-patch.jar,
> PostPatch-144.txt, PostPatch-144fix2.txt
>
>
> A non-jta-data-source is required for DB2 sequences; however,
> org.apache.openjpa.jdbc.conf.JDBCConfigurationImpl does not support a JNDI
> lookup for this data source from the openjpa.ConnectionFactory2Name property
> as documented (refer to section 5.12 and 4.2.1 of the OpenJPA manual).
> It seems like the same implementation for the jta-data-source should be
> implemented for the non-jta-data-source. i.e.
> // ADD createConnectionFactory2()
> private DecoratingDataSource createConnectionFactory2() {
> DataSource ds = (DataSource) connectionFactory2.get();
> if (ds != null)
> return setupConnectionFactory(ds, true);
> ds = (DataSource) super.getConnectionFactory2(); // JNDI lookup
> if (ds == null)
> ds = DataSourceFactory.newDataSource(this, true);
> return setupConnectionFactory(ds, true);
> }
> // MODIFY this method
> public Object getConnectionFactory2() {
> // override to configure data source
> if (dataSource2 == null) {
> DecoratingDataSource ds = createConnectionFactory2();
> dataSource2 = DataSourceFactory.installDBDictionary
> (getDBDictionaryInstance(), ds, this, true);
> }
> return dataSource2;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
