[ 
https://issues.apache.org/jira/browse/OPENJPA-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476320
 ] 

John Stecher commented on OPENJPA-160:
--------------------------------------

Patrick - Tested the patch and it has the same performance as the original 
implementation.  Basically the cost is still in the BrokerImpl newinstance call 
which is setting up the class.  I have attached a profile showing the runtime 
with your patch in it.  If you look closely all we really did was move the cost 
of the BrokerImpl create into the inner class that you created.  The profile 
shows that the <init> method is costing next to nothing compared to the actual 
setup of the class and class variables.  From the best of my knowledge the 
<init> method in the profile is the constructor while the rest of the time is 
class setup overhead.  So given this I'd say we still dont have a fix that 
addresses the issue yet.

John



> Reuse BrokerImpl objects
> ------------------------
>
>                 Key: OPENJPA-160
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-160
>             Project: OpenJPA
>          Issue Type: Sub-task
>            Reporter: Michael Dick
>         Assigned To: Patrick Linskey
>         Attachments: newprofile.jpg, openjpa-160-patch.txt, 
> openjpa-160-patch.txt, perf2.jpg, perf3.jpg
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to