[ 
https://issues.apache.org/jira/browse/OPENJPA-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482409
 ] 

Abe White commented on OPENJPA-175:
-----------------------------------

+1, with some caveats:

- The proposed patch doesn't handle the common cases where the FetchBatchSize 
is -1 (unlimited) or 0 (driver default).
- I'm a little nervous about defaulting the in clause limit to "unlimited" when 
we don't have much info on actual database limits other than Oracle.

> Eager selects by PagingResultObjectProvider may not use the FetchBatchSize
> --------------------------------------------------------------------------
>
>                 Key: OPENJPA-175
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-175
>             Project: OpenJPA
>          Issue Type: Bug
>    Affects Versions: 0.9.0, 0.9.6
>            Reporter: Srinivasa Segu
>         Attachments: OPENJPA-175-patch.txt
>
>
> The PagingResultObjectProvider during initialization does checks to determine 
> the appropriate pageSize. While this logic caps the size to 50 and addresses 
> determining an appropriate page size, it doesn't always conform to the set 
> batch size. For example with the size being 1000 and FetchBatchSize set to 
> say 500, the page size is determined to be 50 resulting in eager selects 
> happening in batches of 50 when the user expects it to be in batches of 500. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to