[
https://issues.apache.org/jira/browse/OPENJPA-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489558
]
Patrick Linskey commented on OPENJPA-182:
-----------------------------------------
Some comments:
1. I don't think that we should be doing work on resolved issues. So, this
should be re-opened, or (preferably) a new issue should be opened for this new
bug.
2. The patch you attached does not use OpenJPA-style formatting. We don't have
a style guide spelled out as well as we probably should, but we always put
spaces after commas, we indent 4 spaces on continuation lines, and we put a
space between an 'if' and the open paren.
3. It's a shame to have to do all this code duplication between DBDictionary
and DB2Dictionary. To what extent can we refactor DBDictionary's methods to
make this concept work out better for DB2Dictionary?
> db2 update lock syntax WITH <isolation> USE AND KEEP UPDATE LOCKS
> ------------------------------------------------------------------
>
> Key: OPENJPA-182
> URL: https://issues.apache.org/jira/browse/OPENJPA-182
> Project: OpenJPA
> Issue Type: New Feature
> Components: jdbc
> Environment: db2 database driver for zOS, AS400, Unix, Windows, Linux
> Reporter: David Wisneski
> Fix For: 0.9.7
>
> Attachments: JIRA182-subselect.patch, OPENJPA-182.patch,
> OPENJPA-182.patch, openJPA182.patch, openjpa182TestCase.jar
>
>
> A while back we changed the syntax of update locking from FOR UPDATE OF to
> WITH RS USE AND KEEP UPDATE LOCKS. Additional changes are required because
> 1. if isolation=serializable is configured, then the syntax should be WITH
> RR USE AND KEEP UDPATE LOCKS
> 2. when using DB2/400 on iSeries machines, the syntax is WITH RS USE AND
> KEEP EXCLUSIVE LOCKS or WITH RR USE AND KEEP EXCLUSIVE LOCKS because DB2/400
> only supports read or exclusive locks.
> 3. DB2 supports both a FETCH FIRST ROWS and update LOCKS clauses.
> So we change supportsLockingWithSelectRange = true in the
> AbstractDB2Dictionary class and change the DB2Dictionary to append the
> correct LOCKS syntax depending on vendor, release and isolation level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
