(Moving a conversation about svn version data in the release to open-jpa-dev)
To elaborate further, right now, I think that we use command-line extraction of this data via some rather ugly mvn. We certainly should be able to get the branch data (or at least the full URL to the root directory). The full URL probably doesn't belong in the version string, but probably does belong in the output of 'java org.apache.openjpa.conf.OpenJPAVersion'. I imagine that we could get better / more concise data if we used JavaSVN or did some scripting or something. Ideally, I'd love it if after graduation, our version IDs looked like this: Leading up to the hypothetical 1.3.2 release: - If from a branch, openjpa-1.3.2-SNAPSHOT-<branch>-<svn#> - If from trunk, openjpa-1.3.2-SNAPSHOT-<svn#> - If from a release branch, openjpa-1.3.2 java org.apache.openjpa.conf.OpenJPAVersion would always include the full URL to the base directory, and the corresponding svn number. -Patrick -- Patrick Linskey BEA Systems, Inc. _______________________________________________________________________ Notice: This email message, together with any attachments, may contain information of BEA Systems, Inc., its subsidiaries and affiliated entities, that may be confidential, proprietary, copyrighted and/or legally privileged, and is intended solely for the use of the individual or entity named in this message. If you are not the intended recipient, and have received this message in error, please immediately return this by email and then delete it. > -----Original Message----- > From: David Ezzio [mailto:[EMAIL PROTECTED] > Sent: Friday, April 27, 2007 1:13 PM > To: Patrick Linskey > Cc: Marc Prud'hommeaux; /USER wls-ejb-dev > Subject: Re: SVN revision needed when checking in openjpa.jar > > Hi Patrick, > > I'm not sure about that first number. My visual SVN client > (SmartSVN) does not show any revisions associated with > directories. I suspect that SVN is like P4 where directories > are artifacts of files and have no independent life of their > own. Do you see a revision number associated with directories? > > In any case, it would be much clearer if the branch name was > inserted into the version info. Can that be done? > > David > > Patrick Linskey wrote: > > The first number is the last revision of the top-level > directory itself. > > We don't change the top-level directory all that much, so > this info is > > mostly useless. > > > > The second number (after the colon) is the last revision > number of the > > svn repository as a whole (i.e., across all of > svn.apache.org, IIRC). > > > > If you see an 'M' after the second number, it means that there are > > local changes. Release builds should not have this M there, ever. > > > > So, IOW, I don't think that we include branching info, although I > > guess it can be inferred from the first number, since the top-level > > dir will be different in a branch. So, from that data, we probably > > have an approximation of the branch, and we know the > globally-unique > > latest svn revision number from when the build happened. > > > > -Patrick > > > > Notice: This email message, together with any attachments, may contain information of BEA Systems, Inc., its subsidiaries and affiliated entities, that may be confidential, proprietary, copyrighted and/or legally privileged, and is intended solely for the use of the individual or entity named in this message. If you are not the intended recipient, and have received this message in error, please immediately return this by email and then delete it.
