Thanks Gonzalo! I just merged your PR with a couple comments if you have some more time. Otherwise, I'll get to it eventually.
P.S. you had it right - Zongwei is my first name :) On Wed, Oct 31, 2018 at 12:39 AM Gonzalo Diethelm < gonzalo.dieth...@gmail.com> wrote: > I just created the PR. > > Caveat: the implementation uses a simple Makefile; it was easier for me > this way. Perhaps you can merge as-is and later I / you / someone else can > migrate this to use the Google tools. Otherwise, let me know and I will try > to do it myself (but that might take a few days). > > Cheers, > Gonzalo > > > On Tue, Oct 30, 2018 at 8:02 PM Gonzalo Diethelm < > gonzalo.dieth...@gmail.com> wrote: > >> Hi Zongwei (or is it Li?), >> >> No, sorry, just came back from a week of holiday. I intend to send it >> over this coming weekend. I will also post here when I finally do it. >> >> Cheers, >> Gonzalo >> >> >> On Tue, Oct 30, 2018 at 5:58 PM Zongwei Li <zong...@google.com> wrote: >> >>> Hey Gonzalo, >>> >>> Just wanted to make sure I didn't miss your pull request. Have you sent >>> it out yet? >>> >>> On Thu, Oct 18, 2018 at 1:25 PM Gonzalo Diethelm < >>> gonzalo.dieth...@gmail.com> wrote: >>> >>>> Oh wow. I just noticed I never saw your reply. I will send a pull >>>> request soon. >>>> >>>> Cheers, >>>> Gonzalo >>>> >>>> >>>> On Fri, May 25, 2018 at 11:39 PM 'Zongwei Li' via Plus Codes Community >>>> Forum <open-location-code@googlegroups.com> wrote: >>>> >>>>> Hey Gonzalo, >>>>> >>>>> Thanks for letting us know about your C implementation. We'd be happy >>>>> to include it as part of the main repo (with attribution, of course). Can >>>>> you send a pull request? >>>>> >>>>> On Thursday, March 22, 2018 at 12:47:16 PM UTC-7, Gonzalo Diethelm >>>>> wrote: >>>>>> >>>>>> Hello everyone, >>>>>> >>>>>> I have implemented the library in C, using the C++ implementation as >>>>>> inspiration / ideas / base. My implementation is on github: >>>>>> https://github.com/gonzus/olc >>>>>> >>>>>> I am happy to contribute this to the project, whether by moving it >>>>>> into the project's github repo, or by you guys linking to my >>>>>> implementation. >>>>>> >>>>>> Cheers, >>>>>> Gonzalo Diethelm >>>>>> >>>>>> -- >>>>> Public site: http://www.openlocationcode.com/ >>>>> Github project: https://github.com/google/open-location-code >>>>> Demo site: http://plus.codes/ >>>>> --- >>>>> You received this message because you are subscribed to a topic in the >>>>> Google Groups "Plus Codes Community Forum" group. >>>>> To unsubscribe from this topic, visit >>>>> https://groups.google.com/d/topic/open-location-code/U8IvkYy8dFg/unsubscribe >>>>> . >>>>> To unsubscribe from this group and all its topics, send an email to >>>>> open-location-code+unsubscr...@googlegroups.com. >>>>> To post to this group, send email to >>>>> open-location-code@googlegroups.com. >>>>> Visit this group at https://groups.google.com/group/open-location-code >>>>> . >>>>> To view this discussion on the web, visit >>>>> https://groups.google.com/d/msgid/open-location-code/2e6158e8-aad6-40cb-929d-7f2dacaefd37%40googlegroups.com >>>>> <https://groups.google.com/d/msgid/open-location-code/2e6158e8-aad6-40cb-929d-7f2dacaefd37%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> >>>> >>>> -- >>>> Gonzalo Diethelm >>>> gonzalo.dieth...@gmail.com >>>> >>> >> >> -- >> Gonzalo Diethelm >> gonzalo.dieth...@gmail.com >> > > > -- > Gonzalo Diethelm > gonzalo.dieth...@gmail.com > -- Public site: http://www.openlocationcode.com/ Github project: https://github.com/google/open-location-code Demo site: http://plus.codes/ --- You received this message because you are subscribed to the Google Groups "Plus Codes Community Forum" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-location-code+unsubscr...@googlegroups.com. To post to this group, send an email to open-location-code@googlegroups.com. Visit this group at https://groups.google.com/group/open-location-code. To view this discussion on the web, visit https://groups.google.com/d/msgid/open-location-code/CAOOjiHegLu0E9eyEBqmUd9wdRxT%2Bi5%2BW9p0dUtgUJr-40oNfkA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
