Maximilian Gass wrote:
> - python-simplejson
> + python-simplejson, libjs-mochikit
depends should be sorted alphabetically.
> +usr/share/javascript/mochikit/MochiKit.js
> usr/share/pyshared/openerp/static/javascript/MochiKit/MochiKit.js
for cosmetical reasons, i prefere writing the leading slash.
> --- /dev/null
> +++ b/debian/patches/mochikit_system
for cosmetical reasons, patches should be named ${number}-foo-bar-baz.patch
> +Reduced MochiKit inclusions to one line, because MochiKit.js contains them
> all
> +on Debian
and they should have a proper header, see e.g. openerp-client for examples.
> - dh $...@}
> + dh --with quilt $...@}
the pathological writing is 'dh $...@} --with quilt', not 'dh --with quilt
$...@}'.
> +override_dh_pysupport:
> + dh_pysupport
> +
> + # Remove MochiKit, we want to use the system-wide one
> + rm -f
> debian/openerp-web/usr/share/pyshared/openerp/static/javascript/MochiKit/*
> +
even when we would remove the file during build time, it would be better
to do it within the install target, and not overwriting pysupport
unecessarily.
however, for obvious reasons, it's better to not include the file in the
tarball in the first place anyway.
i'll push an updated version to the repository soon.
--
Address: Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email: [email protected]
Internet: http://people.panthera-systems.net/~daniel-baumann/
_______________________________________________
open-object mailing list
[email protected]
http://lists.debian-maintainers.org/listinfo/open-object
