On Wed, May 31, 2017 at 6:15 AM, Ilya Okomin <[email protected]> wrote: > Hello, team!
Hi Ilya, > I'm working on patch to add Oracle Linux CPE names support in openscap. > These changes already available in Oracle EL SRPM which Martin Preisler > noticed as upstreamable. > I'm trying to submit patch following existing OpenSCAP contribution process. > As I'm newcomer here and have couple of questions: > > So, first question is regarding right branch to use, I assume it is > 'maint-1.2' though 'master' keeps me awake as well. maint-1.2 is the branch you want to use. The change will automatically get propagated into master after it's merged into maint-1.2. > Could you please also advice if I should just create pull request or need to > open issue describing feature first? Opening a PR is enough. > Do you have code style to follow? Any expected format for xml structured > files, tabs/spaces consideration? Follow the style of the rest of the XML. I wish we had more strict coding style for XML files but we don't :-) > And finally, is there any tests set I should pass before sending openscap > patch via pull request? > Note: Just a guess..I assume on Oracle Linux some tests might fail as there > is 'redhat-release-server' package installed for compatibility and tests > might depend on this. We have a continuous integration system in place. It will run your PR through tests. -- Martin Preisler _______________________________________________ Open-scap-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/open-scap-list
