On Thursday 26 February 2009 15:39:13 Eric Shubert wrote: > Dmitry Torokhov wrote: > > Hi Eric, > > > > Thank you very much for your report. > > > > On Thursday 26 February 2009 08:17:47 Eric Shubert wrote: > >> I've attempted to compile subject, ran into a few snags, and have a few > >> solutions. > >> > >> vmxnet.c build failed with: > >> make[3]: Entering directory > >> `/usr/src/open-vm-tools-2009.02.18-148847/modules/linux/vmxnet' > >> In file included from /lib/modules/2.4.36/build/include/asm/dma.h:14, > >> from vmxnet.c:34: > >> /lib/modules/2.4.36/build/include/linux/delay.h:62: error: parse error > >> before "const" > >> make[3]: *** [vmxnet.o] Error 1 > >> > >> I couldn't see what the problem with linux/delay.h exactly was, but it > >> doesn't appear to be necessary. I tried removing > >> #include <asm/dma.h> > >> from vmxnet.c, and the only complaint from the compiler was the lack of > >> the udelay function, which is defined in <asm/delay.h>. It appears that > >> asm/dma.h was including linux/delay.h, which in turn included > >> asm/delay.h, which contained the udelay definition. I replaced > >> <asm/dma.h> with <asm/delay.h>, and vmxnet.c compiled clean. Of course > >> whether it actually works or not is another question. > > > > This should indeed work. > > > >> The next error was with vmhgfs. Makefile.normal had specified > >> hgfsEscapeLinux.o, while the program was really hgfsEscape.o (the > >> "Linux" part had apparently been dropped along the line). I modified > >> Makefile.normal, specifying hgfsEscape.o, and it compiled clean. Can > >> someone verify if this is correct? > > > > Yes, that is correct. There should already be hgfsEscape.o in the list of > > dependencies so you can just remove hgfsEscapeLinux.o > > > >> With vmsock, I get this: > >> make[4]: Entering directory > >> `/usr/src/open-vm-tools-2009.02.18-148847p/modules/linux/vsock/driver-2. > >>4.3 6' Compiling .././linux/af_vsock.c > >> ../linux/af_vsock.c: In function `VSockVmciStreamConnect': > >> ../linux/af_vsock.c:3466: warning: implicit declaration of function > >> `DEFINE_WAIT' > >> ../linux/af_vsock.c:3466: error: `wait' undeclared (first use in this > >> function) > >> ../linux/af_vsock.c:3466: error: (Each undeclared identifier is reported > >> only once > >> ../linux/af_vsock.c:3466: error: for each function it appears in.) > >> ../linux/af_vsock.c:3542: warning: implicit declaration of function > >> `prepare_to_wait' > >> ../linux/af_vsock.c:3577: warning: implicit declaration of function > >> `finish_wait' > >> ../linux/af_vsock.c: In function `VSockVmciAccept': > >> ../linux/af_vsock.c:3615: error: `wait' undeclared (first use in this > >> function) > >> ../linux/af_vsock.c: In function `VSockVmciStreamSendmsg': > >> ../linux/af_vsock.c:4360: error: `wait' undeclared (first use in this > >> function) > >> ../linux/af_vsock.c: In function `VSockVmciStreamRecvmsg': > >> ../linux/af_vsock.c:4714: error: `wait' undeclared (first use in this > >> function) > >> make[4]: *** [af_vsock.o] Error 1 > >> make[4]: Leaving directory > >> `/usr/src/open-vm-tools-2009.02.18-148847p/modules/linux/vsock/driver-2. > >>4.3 6' > >> > >> Can someone explain what might be the problem here? I don't expect > >> vmsock to be useful in the IPCop distro, but I'm wondering what the > >> problem is, as it should build with this kernel. > > > > Could you please try the patch below? You will need to apply it to all > > copies of compat_wait.h in the tree. Thanks! > > I've applied the patch to all copies of compat_wait.h: > open-vm-tools-2009.02.18-148847/modules/linux/vmmemctl/compat_wait.h > open-vm-tools-2009.02.18-148847/modules/linux/vmhgfs/compat_wait.h > open-vm-tools-2009.02.18-148847/modules/linux/vsock/include/compat_wait.h > open-vm-tools-2009.02.18-148847/modules/linux/vmblock/include/compat_wait.h > open-vm-tools-2009.02.18-148847/modules/linux/vmci/compat_wait.h > and everything compiled ok.
Cool, thank you for doing that. > > It should be noted that, as IPCop doesn't have a GUI (it typically runs > headless), I used the following configuration: > ./configure --disable-static \ > --disable-multimon \ > --without-gtk2 \ > --without-gtkmm \ > --without-icu \ > --without-x \ > --with-kernel-release=2.4.36 > TTBOMK the only module using compat_wait.h with this configuration is > vsock. > > Do you have any idea which release will contain all of these changes > (vmxnet.c, vmhgfs/Makefile.normal, compat_wait.h)? > The next month refresh should pick it all up. -- Dmitry ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ open-vm-tools-devel mailing list open-vm-tools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/open-vm-tools-devel
