Tracker item #3369135, was opened at 2011-07-16 22:18
Message generated for change (Comment added) made by mvanzin
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=3369135&group_id=204462

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Out of Date
Priority: 5
Private: No
Submitted By: sohrkim (tsohr)
Assigned to: Nobody/Anonymous (nobody)
Summary: Some patches and modifications

Initial Comment:
I'm using Fedora 14, with this...
--> Linux ** 2.6.35.13-92.fc14.x86_64 #1 SMP Sat May 21 17:26:25 UTC 2011 
x86_64 x86_64 x86_64 GNU/Linux

and, VMWare Workstation 7.0

Thank you very much! 

But, it needs to be fix some case.

1. configure missed libXScrnSaver-devel, and missed link library -lXss for the 
unity project.
2. kernel-2.6.35 might be re-factoring(?), and here is some diffs.

[root@tsohr tmp]# diff -r open-vm-tools-8.4.2-261024 open-vm-tools-tsohr/ |grep 
-v "^Only in" 
diff -r open-vm-tools-8.4.2-261024/modules/linux/vmxnet/vmxnet.c 
open-vm-tools-tsohr/modules/linux/vmxnet/vmxnet.c
2795c2795
<     struct dev_mc_list *dmi = dev->mc_list;
---
>     struct netdev_hw_addr *dmi = NULL;
2805,2807c2805,2808
<     for (i = 0; i < dev->mc_count; i++){
<       addrs = dmi->dmi_addr;
<       dmi   = dmi->next;
---
>     i = 0;
>     netdev_for_each_mc_addr (dmi, dev)
>     {
>       addrs = dmi->addr;
2828a2830,2831
> 
>         i++;
diff -r open-vm-tools-8.4.2-261024/modules/linux/vmxnet3/vmxnet3.c 
open-vm-tools-tsohr/modules/linux/vmxnet3/vmxnet3.c
2303c2303
<    uint32 sz = netdev->mc_count * ETH_ALEN;
---
>    uint32 sz = netdev_mc_count(netdev) * ETH_ALEN;
2310,2313c2310,2312
<          int i;
<          struct dev_mc_list *mc = netdev->mc_list;
< 
<          for (i = 0; i < netdev->mc_count; i++) {
---
>          int i = 0;
>          struct netdev_hw_addr *mc;
>          netdev_for_each_mc_addr(mc, netdev) {
2315,2316c2314
<             memcpy(buf + i * ETH_ALEN, mc->dmi_addr, ETH_ALEN);
<             mc = mc->next;
---
>             memcpy(buf + i * ETH_ALEN, mc->addr, ETH_ALEN);
2357c2355
<       if (netdev->mc_count > 0) {
---
>       if (netdev_mc_count(netdev) > 0) {
2361c2359
<             rxConf->mfTableLen = netdev->mc_count * ETH_ALEN;
---
>             rxConf->mfTableLen = netdev_mc_count(netdev) * ETH_ALEN;
diff -r open-vm-tools-8.4.2-261024/modules/linux/vsock/linux/af_vsock.c 
open-vm-tools-tsohr/modules/linux/vsock/linux/af_vsock.c
3224c3224
<    compat_init_prepare_to_wait(sk->compat_sk_sleep, &wait, 
TASK_INTERRUPTIBLE);
---
>    compat_init_prepare_to_wait(compat_sk_sleep(sk), &wait, 
> TASK_INTERRUPTIBLE);
3247c3247
<       compat_cont_prepare_to_wait(sk->compat_sk_sleep, &wait, 
TASK_INTERRUPTIBLE);
---
>       compat_cont_prepare_to_wait(compat_sk_sleep(sk), &wait, 
> TASK_INTERRUPTIBLE);
3259c3259
<    compat_finish_wait(sk->compat_sk_sleep, &wait, TASK_RUNNING);
---
>    compat_finish_wait(compat_sk_sleep(sk), &wait, TASK_RUNNING);
3319c3319
<    compat_init_prepare_to_wait(listener->compat_sk_sleep, &wait, 
TASK_INTERRUPTIBLE);
---
>    compat_init_prepare_to_wait(compat_sk_sleep(listener), &wait, 
> TASK_INTERRUPTIBLE);
3335c3335
<       compat_cont_prepare_to_wait(listener->compat_sk_sleep, &wait, 
TASK_INTERRUPTIBLE);
---
>       compat_cont_prepare_to_wait(compat_sk_sleep(listener), &wait, 
> TASK_INTERRUPTIBLE);
3369c3369
<    compat_finish_wait(listener->compat_sk_sleep, &wait, TASK_RUNNING);
---
>    compat_finish_wait(compat_sk_sleep(listener), &wait, TASK_RUNNING);
3467c3467
<    poll_wait(file, sk->compat_sk_sleep, wait);
---
>    poll_wait(file, compat_sk_sleep(sk), wait);
4107c4107
<    compat_init_prepare_to_wait(sk->compat_sk_sleep, &wait, 
TASK_INTERRUPTIBLE);
---
>    compat_init_prepare_to_wait(compat_sk_sleep(sk), &wait, 
> TASK_INTERRUPTIBLE);
4144c4144
<          compat_cont_prepare_to_wait(sk->compat_sk_sleep,
---
>          compat_cont_prepare_to_wait(compat_sk_sleep(sk),
4197c4197
<    compat_finish_wait(sk->compat_sk_sleep, &wait, TASK_RUNNING);
---
>    compat_finish_wait(compat_sk_sleep(sk), &wait, TASK_RUNNING);
4431c4431
<    compat_init_prepare_to_wait(sk->compat_sk_sleep, &wait, 
TASK_INTERRUPTIBLE);
---
>    compat_init_prepare_to_wait(compat_sk_sleep(sk), &wait, 
> TASK_INTERRUPTIBLE);
4471c4471
<       compat_cont_prepare_to_wait(sk->compat_sk_sleep, &wait, 
TASK_INTERRUPTIBLE);
---
>       compat_cont_prepare_to_wait(compat_sk_sleep(sk), &wait, 
> TASK_INTERRUPTIBLE);
4537c4537
<    compat_finish_wait(sk->compat_sk_sleep, &wait, TASK_RUNNING);
---
>    compat_finish_wait(compat_sk_sleep(sk), &wait, TASK_RUNNING);

3. docs/api/ builds some weird output, ##{BUILD_OUTPUT}## and 
##{WARNING_LOG}##, 
   and i had to relocate ##{BUILD_OUTPUT}##/html to build/html. 



----------------------------------------------------------------------

>Comment By: Marcelo Vanzin (mvanzin)
Date: 2011-07-20 16:39

Message:
You haven't specified the version of open-vm-tools you're using; but I'm
pretty sure all the issues you mention have been fixed in the last few
unstable releases.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=3369135&group_id=204462

------------------------------------------------------------------------------
10 Tips for Better Web Security
Learn 10 ways to better secure your business today. Topics covered include:
Web security, SSL, hacker attacks & Denial of Service (DoS), private keys,
security Microsoft Exchange, secure Instant Messaging, and much more.
http://www.accelacomm.com/jaw/sfnl/114/51426210/
_______________________________________________
open-vm-tools-devel mailing list
open-vm-tools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open-vm-tools-devel

Reply via email to