> > Hmm, the intent of this install-exec-hook is, among other things, to > > ensure that hgfsmounter is setuid root, which is why the chown is > > there. > > > > But I guess you're saying that it's not necessary because of the > > following logic: 1) The user can run 'make install' as is, or under > > sudo/su. 2) If sudo/su isn't used, there's no way to establish setuid > > root on the binary anyway. 3) If sudo/su is used, 'make install' > > will guarantee that the owner/group is root by virtue of the fact > > that the default actions for bin_PROGRAMS or sbin_PROGRAMS is to > > install the file as the current user. > > > > Is that correct? If so, I'll remove the chown. > > Yes this is correct. > > Typically things like setuid or file ownerships are managed by the > package spec file. > > > >> - The module installation ignores DESTDIR, and so will also fail as > >> part of an non-root RPM build. > > > > Are you sure about that? I see this code in modules/Makefile.am: > > I'm sorry, my statement was inaccurate. The problem is the call to > 'depmod', which requires root privileges. I would recommend to provide > a > configure option that disables the call to depmod. Similar options are > very common for example in gnome applications, to disable the call to > the desktop or mime info installation script (packagers prefer to do > this from the spec files). > > > >> - mount.vmhgfs gets installed in /usr/sbin instead of /sbin
Here's a patch to address the three make install issues. Let me know if it works for you and I'll apply it to the git repo.
make_install_fixes.patch
Description: make_install_fixes.patch
------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________ open-vm-tools-discuss mailing list open-vm-tools-discuss@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/open-vm-tools-discuss
