I see. The change looks fine.
Sun
On Sat, Jul 3, 2010 at 11:58 AM, David Coakley <dcoak...@gmail.com> wrote:
> That change is to avoid compilation warnings like these:
>
> ../../../open64/osprey-gcc-4.2.0/gcc/system.h:609:25: warning: C++
> style comments are not allowed in ISO C90
>
> This warning appears when using newer versions of gcc (> 4.2?) as the
> build compiler.
>
> On Fri, Jul 2, 2010 at 6:35 PM, Sun Chan <sun.c...@gmail.com> wrote:
> > just curious, most of the change is comments from C++ "//" to C style.
> Why?
> > Sun
> >
> > On Sat, Jul 3, 2010 at 8:39 AM, David Coakley <dcoak...@gmail.com>
> wrote:
> >>
> >> Hello all,
> >>
> >> Could one of the gatekeepers please review the attached code cleanup
> >> patch? It is intended to eliminate the compilation warnings seen when
> >> building osprey-gcc-4.2.0. Changes are mostly cosmetic; the details
> >> are:
> >>
> >> - Follow gcc 4.2.0 coding conventions and use C89-style comments and
> >> declarations.
> >> - Correct the prototypes for the mangle_decl hook function.
> >> - Clarify "(DECL_REGISTER(t) && DECL_HARD_REGISTER(t))" condition.
> >> - Ensure global variable "bases" is initialized.
> >>
> >> Also, I have not heard from anyone about my last patch, posted one week
> >> ago:
> >>
> >>
> >>
> http://sourceforge.net/mailarchive/message.php?msg_name=AANLkTilfr9A_vws0DGwitrIoj6g4eMtRwXCmM_sIGqKF%40mail.gmail.com
> >>
> >> I would like to request that the gatekeepers acknowledge incoming
> >> patches more quickly. Thanks,
> >>
> >> -David Coakley / AMD Open Source Compiler Engineering
> >>
> >>
> >>
> ------------------------------------------------------------------------------
> >> This SF.net email is sponsored by Sprint
> >> What will you do first with EVO, the first 4G phone?
> >> Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
> >> _______________________________________________
> >> Open64-devel mailing list
> >> Open64-devel@lists.sourceforge.net
> >> https://lists.sourceforge.net/lists/listinfo/open64-devel
> >>
> >
> >
>
------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel
