It looks fine to me. Please commit it. 在 2010年9月6日 下午6:42，Chen, Rui (Roger, TSG-GDCC-SH) <rui.c...@hp.com>写道：
> It’s not working for the previous bug. > > > > For bug 582, the assembler_name of newdecl is NULL, but not NULL for > olddecl. In that case, we need to set the assembler_name of olddecl to NULL. > > > > Regards, > > Roger > > > > *From:* Jian-Xin Lai [mailto:laij...@gmail.com] > *Sent:* 2010年9月7日 0:53 > *To:* Chen, Rui (Roger, TSG-GDCC-SH) > *Subject:* Re: [Open64-devel] patch to fix g++ builtin regression tests > fails > > > > How about using the original code: > COPY_DECL_ASSEMBLER_NAME (olddecl, newdecl); > > Is it working for both the two bugs? > > 2010/9/6 Chen, Rui (Roger, TSG-GDCC-SH) <rui.c...@hp.com> > > Hi, > > > > Can gatekeeper help to review this patch? This is a fix for bug 627 ( > https://bugs.open64.net/show_bug.cgi?id=627), 3 tests in gcc regression > test suite failed due to r3327 check-in. > > > > I attached the diff file and those 3 test cases. > > > > This bug is caused by DECL_ASSEMBLER_NAME macro will set assembler_name if > it’s null. And later in maybe_apply_renaming_pragma function, open64 will > check whether DECL_ASSEMBLER_NAME is already set or not. If we had set this > name, it will give a warning instead of change it. > > > > This fix will try to not generate assembler_name, so the name can be > generated later in maybe_apply_renaming_pragma function. > > > > Regards, > > Roger > > > > ------------------------------------------------------------------------------ > This SF.net Dev2Dev email is sponsored by: > > Show off your parallel programming skills. > Enter the Intel(R) Threading Challenge 2010. > http://p.sf.net/sfu/intel-thread-sfd > _______________________________________________ > Open64-devel mailing list > Open64-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/open64-devel > > > > > -- > Regards, > Lai Jian-Xin > -- Regards, Lai Jian-Xin
------------------------------------------------------------------------------ Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________ Open64-devel mailing list Open64-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/open64-devel
