Looks good to me. Though I am not a gate keeper on installation scripts, I supported libhugetlbfs in the past, so I jumped in here.
-Mei > -----Original Message----- > From: Gilmore, Doug [mailto:doug.gilm...@amd.com] > Sent: Monday, September 20, 2010 3:27 PM > To: open64-devel@lists.sourceforge.net > Subject: Re: [Open64-devel] Review request: problem with -HP option > > Sorry, I flubbed the attachment -- here it is. > > Doug > > > -----Original Message----- > > From: Gilmore, Doug [mailto:doug.gilm...@amd.com] > > Sent: Monday, September 20, 2010 2:52 PM > > To: open64-devel@lists.sourceforge.net > > Subject: [Open64-devel] Review request: problem with -HP option > > > > Commit r3284, exposed a problem in the code in the compiler driver > > which optionally adds one of the libhugetlbfs linker script, which > > for example, broke compiling/linking with -HP:bdt=2m. > > > > The straightforward fix is just to install the linker scripts into the > > new '64' subdirectory, even though longer term it would be good to > > clean up the code that optionally adds the libhugetlbfs linker script. > > > > The patch also contains one cleanup change that removes an error > > message that is innocuously generated when the install script is run > > more than once. > > > > Could someone review this change? > > > > Thanks, > > > > Doug > > > > > > ----------------------------------------------------------------------- > > ------- > > Start uncovering the many advantages of virtual appliances > > and start using them to simplify application deployment and > > accelerate your shift to cloud computing. > > http://p.sf.net/sfu/novell-sfdev2dev > > _______________________________________________ > > Open64-devel mailing list > > Open64-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/open64-devel ------------------------------------------------------------------------------ Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev _______________________________________________ Open64-devel mailing list Open64-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/open64-devel
