I was about to submit a similar patch for the same issue (see below).
I think either one will work.
-David Coakley / AMD Open Source Compiler Engineering
Index: osprey/targdir_lib/Makefile.in
===================================================================
--- osprey/targdir_lib/Makefile.in (revision 3368)
+++ osprey/targdir_lib/Makefile.in (working copy)
@@ -14,6 +14,11 @@
libmv : libacml_mv
endif
+# If building libopen64rt, build it before all other libraries.
+ifneq (,$(findstring libopen64rt,$(SUBDIRS)))
+$(filter-out libopen64rt,$(SUBDIRS)) : libopen64rt
+endif
+
$(SUBDIRS):
@echo "MAKE $(ACTION) in $(PWD)/$@"; \
$(MAKE) $(if $V,,--no-print-directory) -C $@ $(ACTION)
On Tue, Oct 12, 2010 at 2:44 AM, Sun Chan <sun.c...@gmail.com> wrote:
> looks fine to me.
> Sun
>
> On Tue, Oct 12, 2010 at 4:27 PM, Wu Yongchong <wuyongch...@gmail.com> wrote:
>> Hi,
>> can gatekeeper help review this patch,
>>
>> Open64 use itself to build it's library, when building the share
>> library, the opencc default link libopen64rt_share.a, so all the
>> other libraries should depend on libopen64rt.
>> Without this dependency, it may fault when doing -j make.
>> following is a patch
>>
>> Index: osprey/targdir_lib/Makefile.in
>> ===================================================================
>> --- osprey/targdir_lib/Makefile.in (revision 1211)
>> +++ osprey/targdir_lib/Makefile.in (working copy)
>> @@ -14,6 +14,11 @@
>> libmv : libacml_mv
>> endif
>>
>> +ifneq (,$(findstring libopen64rt,$(SUBDIRS)))
>> +OTHERDIRS=$(subst libopen64rt,,$(SUBDIRS) )
>> +$(OTHERDIRS): libopen64rt
>> +endif
>> +
>> $(SUBDIRS):
>> �...@echo "MAKE $(ACTION) in $(PWD)/$@"; \
>> $(MAKE) $(if $V,,--no-print-directory) -C $@ $(ACTION)
>>
>>
>> --
>> yongchong
>>
>> ------------------------------------------------------------------------------
>> Beautiful is writing same markup. Internet Explorer 9 supports
>> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
>> Spend less time writing and rewriting code and more time creating great
>> experiences on the web. Be a part of the beta today.
>> http://p.sf.net/sfu/beautyoftheweb
>> _______________________________________________
>> Open64-devel mailing list
>> Open64-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/open64-devel
>>
>
> ------------------------------------------------------------------------------
> Beautiful is writing same markup. Internet Explorer 9 supports
> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
> Spend less time writing and rewriting code and more time creating great
> experiences on the web. Be a part of the beta today.
> http://p.sf.net/sfu/beautyoftheweb
> _______________________________________________
> Open64-devel mailing list
> Open64-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/open64-devel
>
------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
Spend less time writing and rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel
