> -----Original Message----- > From: Sun Chan [mailto:sun.c...@gmail.com] > Sent: Tuesday, October 12, 2010 3:29 PM > To: Gilmore, Doug > Cc: Open64-devel > Subject: Re: [Open64-devel] review/approval request for libhugetlbfs > bug fix. > > i don't know, the original code has "close(fd) at the end, your new > code does not. is this by design? > Sun Yes, the old code only did one read, while the new version reads one mount entry at a time. Thus the old code didn't handle an arbitrary number of mounts, the new version does.
Doug > > On Wed, Oct 13, 2010 at 1:55 AM, Gilmore, Doug <doug.gilm...@amd.com> > wrote: > > The patch is attached to the bug report: > > > > https://bugs.open64.net/show_bug.cgi?id=667 > > > > Mei has already reviewed it, so it probably just needs > > an approval from a gate keeper. > > > > Doug > > > > > > --------------------------------------------------------------------- > --------- > > Beautiful is writing same markup. Internet Explorer 9 supports > > standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. > > Spend less time writing and rewriting code and more time creating > great > > experiences on the web. Be a part of the beta today. > > http://p.sf.net/sfu/beautyoftheweb > > _______________________________________________ > > Open64-devel mailing list > > Open64-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/open64-devel > > ------------------------------------------------------------------------------ Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb _______________________________________________ Open64-devel mailing list Open64-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/open64-devel