I think I've modified all "WN_set_operator" invocations to "WN_change_operator" 
in wopt. Only one call in opt_symb.cxx causes problem, so I have to manually 
reset its map_id to -1 before call WN_change_operator.

Regards,
Roger

-----Original Message-----
From: Sun Chan [mailto:[email protected]] 
Sent: 2010年11月1日 14:43
To: Chen, Rui (Roger, TSG-GDCC-SH)
Cc: [email protected]
Subject: Re: [Open64-devel] Review request for map_id problem

looks good. OTOH, is this the only place that uses set_operator? If so, should 
they need to be changed to your new scheme?
Sun

2010/10/31 Chen, Rui (Roger, TSG-GDCC-SH) <[email protected]>:
> I modified the patch a little bit, creating a new "WN_change_operator"
> method to avoid many duplicate assertions.
>
>
>
> Pls help to review it again. Thanks.
>
>
>
> Regards,
>
> Roger
>
>
>
> From: Chen, Rui (Roger, TSG-GDCC-SH)
> Sent: 2010年10月29日 13:51
> To: [email protected]
> Subject: [Open64-devel] Review request for map_id problem
>
>
>
> Hi all,
>
>
>
> I found that some code changes OPERATOR of a whirl node without reset 
> its map_id. This causes problems if the new OPERATOR belongs to a 
> different mapcat than the old OPERATOR.
>
>
>
> I attached a test case, compile the test case using "opencc -O3 -c min.ii"
> causes assertion fault:
>
>
>
> ### Assertion failure at line 875 of
> /home/chenr/workspace/open64_backup_build/osprey/../../open64_backup/osprey/be/opt/opt_verify.cxx:
>
> ### Compiler Error in file min.ii during Global Optimization -- Verify 
> Live-Range phase:
>
> ### Verify_version_CR: Found no-def, but current statement is not 
> entry chi
>
>
>
> I attached a patch to fix this problem. Pls help to review the changes.
>
>
>
> Regards,
>
> Roger
>
> ----------------------------------------------------------------------
> -------- Nokia and AT&T present the 2010 Calling All Innovators-North 
> America contest Create new apps & games for the Nokia N8 for consumers 
> in  U.S. and Canada
> $10 million total in prizes - $4M cash, 500 devices, nearly $6M in 
> marketing Develop with Nokia Qt SDK, Web Runtime, or Java and Publish 
> to Ovi Store http://p.sf.net/sfu/nokia-dev2dev 
> _______________________________________________
> Open64-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/open64-devel
>
>
------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in  U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store 
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
Open64-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/open64-devel

Reply via email to