For the first comment, it->second is right. It's the reference of the
'value' part of the pair in the map.
I'll change the code according to your comments and check in. Thank you very
much.
2010/11/29 Sun Chan <sun.c...@gmail.com>
> looks fine, except a couple of minor things
> Sun
>
> in emitter.cxx, is this right
> else {
> new_idx = it->second + 1;
> }
> ??
> shouldn't this be it->second()?
>
> WSSA_VSYM_TYPE, I would add FmtAssert outside of the switch. If people
> add new cases and forgot to return inside the case stmt, you will have
> return with no return value.
>
> Some more on spacing style. Your unary operator sometimes is separated
> by a space, sometimes not. I think you should remove the space and
> stay consistent. E.g. "! var" does not make the code any easier to
> read than "!var"
>
>
>
>
> On Thu, Nov 18, 2010 at 9:42 AM, Jian-Xin Lai <laij...@gmail.com> wrote:
> > Hi Sun,
> >
> > Could you please review the code for WHIRL SSA WOPT emitter? This emitter
> is
> > used to translate the HSSA into WHIRL SSA. The wssa_emitter.h and
> > wssa_emitter.cxx provide the interface and implementation to translate
> the
> > WOPT symtab, HSSA CODEREP, HSSA phi node, HSSA chi node, HSSA mu node to
> > WSSA symtab, WSSA version, WSSA phi node, WSSA chi node, WSSA mu node
> > respectively.
> > The changes in be/opt will invoke these functions to generate WHIRL SSA
> in
> > either PreOPT or MainOPT.
> >
> > Thank you very much.
> >
> > --
> > Regards,
> > Lai Jian-Xin
> >
> >
> ------------------------------------------------------------------------------
> > Beautiful is writing same markup. Internet Explorer 9 supports
> > standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
> > Spend less time writing and rewriting code and more time creating great
> > experiences on the web. Be a part of the beta today
> > http://p.sf.net/sfu/msIE9-sfdev2dev
> > _______________________________________________
> > Open64-devel mailing list
> > Open64-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/open64-devel
> >
> >
>
--
Regards,
Lai Jian-Xin
------------------------------------------------------------------------------
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel
