I wondered what PHONY is doing there also. Please go ahead checkin sun On Tue, Dec 7, 2010 at 7:23 AM, David Coakley <dcoak...@gmail.com> wrote: > For some unknown reason the makefile generated by IPA includes an > .IGNORE directive which tells GNU make to ignore execution errors. > Apparently this directive was broken in GNU make until version 3.81 > and so it did no harm. Recently we've started testing on more systems > that use GNU make 3.81 by default, such as RHEL 5.5. On those systems > compilations that use IPA will return a zero exit status (success) to > the calling process even when there is a compilation failure. > > Taking the directive out makes IPA linking behave the same regardless > of the version of GNU make on the system -- we get an error code > returned when the compilation fails. > > Could a gatekeeper please review the patch? Thanks, > > -David Coakley / AMD Open Source Compiler Engineering > > Index: osprey/ipa/common/ipc_compile.cxx > =================================================================== > --- osprey/ipa/common/ipc_compile.cxx (revision 3422) > +++ osprey/ipa/common/ipc_compile.cxx (working copy) > @@ -1,4 +1,8 @@ > /* > + * Copyright (C) 2010 Advanced Micro Devices, Inc. All Rights Reserved. > + */ > + > +/* > * Copyright 2003, 2004, 2005, 2006 PathScale, Inc. All Rights Reserved. > */ > > @@ -844,7 +848,6 @@ > fprintf(makefile, "%s = %s\n\n", executable_macro_name, executable); > fprintf(makefile, ".PHONY: default\n"); > fprintf(makefile, "default: %s\n\n", executable_macro); > - fprintf(makefile, ".IGNORE: %s\n\n", executable_macro); > #ifdef KEY > // bug 2487 > // bug 3594: emit backslash if there is only symtab.o > > ------------------------------------------------------------------------------ > What happens now with your Lotus Notes apps - do you make another costly > upgrade, or settle for being marooned without product support? Time to move > off Lotus Notes and onto the cloud with Force.com, apps are easier to build, > use, and manage than apps on traditional platforms. Sign up for the Lotus > Notes Migration Kit to learn more. http://p.sf.net/sfu/salesforce-d2d > _______________________________________________ > Open64-devel mailing list > Open64-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/open64-devel >
------------------------------------------------------------------------------ What happens now with your Lotus Notes apps - do you make another costly upgrade, or settle for being marooned without product support? Time to move off Lotus Notes and onto the cloud with Force.com, apps are easier to build, use, and manage than apps on traditional platforms. Sign up for the Lotus Notes Migration Kit to learn more. http://p.sf.net/sfu/salesforce-d2d _______________________________________________ Open64-devel mailing list Open64-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/open64-devel
