Could a gatekeeper please review the attached patch to completely remove the -compat-gcc option?
I noticed this option because its implementation relies on some non-portable code, a weak symbol. When I investigated its uses, I couldn't find anything that was worthwhile. The proposed log message msg.txt details my findings. Thanks, -David Coakley / AMD Open Source Compiler Engineering
Remove undocumented -compat-gcc driver option. The effects of this option appear unnecessary and its implementation is not portable since it relies on a weak symbol. o In add_final_ld_args(), all code related to -compat-gcc is commented out. The current behavior, to leave out libopen64rt when -nostdlib is specified, is consistent with gcc and its handling of libgcc. o In file_utils.c the weak symbol and the function want_directory() are dead code because the handling for -I and -L in table.c does not normally pass a path with '-' as the first character, and there's no way to turn -compat-gcc off. o In main(), -compat-gcc is used to generate a warning instead of an error when an unrecognized single-dash option is seen. Removing this code makes opencc more compatible with gcc, where unrecognized single-dash options are treated as errors. o In display_version(), -compat-gcc causes the compiler to report the version of the gcc frontend instead of the Open64 version when the -dump-version option is used. There is no need for this behavior since -dump-version is an Open64-specific option.
compat_gcc.diff
Description: Binary data
------------------------------------------------------------------------------ Lotusphere 2011 Register now for Lotusphere 2011 and learn how to connect the dots, take your collaborative environment to the next level, and enter the era of Social Business. http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________ Open64-devel mailing list Open64-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/open64-devel
