Hi David, Looks good. Please go ahead.
- Suneel On Thu, Dec 16, 2010 at 9:24 PM, David Coakley <dcoak...@gmail.com> wrote: > In trunk commit r3435, std::ostream was introduced into > osprey/common/com/symtab_defs.h. With older versions of gcc, the > include of <ext/slist> in symtab.h (the file that is normally included > to get symtab_defs.h) indirectly brought in <iosfwd> and resolved the > declaration. More recently the gcc developers have cleaned up the > dependencies of the libstdc++ header files and <ext/slist> no longer > includes <iosfwd>. The result is that osprey/common/com/config.cxx > fails to compile with gcc-4.5.1 as of r3435. > > Since <ext/slist> is not needed in symtab.h, my fix is to replace it > with <iosfwd>, the file that is really required. > > Could a gatekeeper please review the change below? Thanks, > > -David Coakley / AMD Open Source Compiler Engineering > > > Index: osprey/common/com/symtab.h > =================================================================== > --- osprey/common/com/symtab.h (revision 3437) > +++ osprey/common/com/symtab.h (working copy) > @@ -1,5 +1,5 @@ > /* > - * Copyright (C) 2009 Advanced Micro Devices, Inc. All Rights Reserved. > + * Copyright (C) 2009-2010 Advanced Micro Devices, Inc. All Rights Reserved. > */ > > /* > @@ -49,7 +49,7 @@ > // This file should contain only inlined functions for accessing various > // fields in the symbol table classes. > > -#include <ext/slist> > +#include <iosfwd> > > #ifndef segmented_array_INCLUDED > #include "segmented_array.h" > > ------------------------------------------------------------------------------ > Lotusphere 2011 > Register now for Lotusphere 2011 and learn how > to connect the dots, take your collaborative environment > to the next level, and enter the era of Social Business. > http://p.sf.net/sfu/lotusphere-d2d > _______________________________________________ > Open64-devel mailing list > Open64-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/open64-devel > ------------------------------------------------------------------------------ Lotusphere 2011 Register now for Lotusphere 2011 and learn how to connect the dots, take your collaborative environment to the next level, and enter the era of Social Business. http://p.sf.net/sfu/lotusphere-d2d _______________________________________________ Open64-devel mailing list Open64-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/open64-devel
