Looks good to me. Ljx, can you double check?
Thx!
Sun
On Mon, Jan 17, 2011 at 10:13 AM, Richard D. Li <lipt...@gmail.com> wrote:
> Hi,
> can a gatekeeper review the attached patch?
>
> Function Allocate_Object in data_layout.cxx intends to
> allocate zero-initialized objects in bss, by checking the
> ST_INIT_VALUE_ZERO flag of each ST. But wgen only sets the flag
> for integer types, and as a result initialized arrays and
> structs are always left in data section:
>
> int w = 2; /* data */
> int x = 0; /* bss */
> int y[2] = {0,0}; /* data */
> struct A z = {0}; /* data */
>
> Several files in spec and from other sources are found to
> contain such zero initializations of arrays and structs,
> e.g. about 7.5% of data section for 255.vortex (in spec2000)
> are zero arrays.
>
> This patch adds code to wgen to apply the ST_INIT_VALUE_ZERO flag
> for zero-initialized arrays and structures, and has the effect of moving
> y and z in the above case to bss. This will result in smaller .o and
> executable files (not affecting runtime memory footprint, though),
> and does not affect performance (shown by spec2006). I ran a test
> with gcc regression test and found no new failures.
>
> Can a gatekeeper help review it? Thanks.
>
> Richard
>
> ------------------------------------------------------------------------------
> Protect Your Site and Customers from Malware Attacks
> Learn about various malware tactics and how to avoid them. Understand
> malware threats, the impact they can have on your business, and how you
> can protect your company and customers by using code signing.
> http://p.sf.net/sfu/oracle-sfdevnl
> _______________________________________________
> Open64-devel mailing list
> Open64-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/open64-devel
>
>
------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand
malware threats, the impact they can have on your business, and how you
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel
